qtile / qtile / 6075790414

76%

Build Type

push

github

Committed by tych0

Commit Message

Fix number of bugs in the bar

c840df2 introduced a change to Bar.draw to ensure that a bar was
completely filled even when there were insufficient widgets to fill the
bar.

However, this introduced a bug:

1) When the bar is drawn, it clears the entire bar and then redraws
   every widget. However, the clearing is unnecessary as widgets also
   clear the surface before they are drawn. The bar's clearing therefore
   results in flickering of the bar as there may be a gap between
   clearing the bar and the widgets drawing themselves, particularly
   when there are a large number of widgets in the bar.

That bug revealed another:

2) Drawing the borders also cleared the entire bar so flickering would
   also occur when a user used borders in their config.

Which, in turn, revealed another:

3) Bar borders were not being rendered correctly for vertical bars
   (surprised this wasn't flagged earlier...)

This PR addresses all of these issues by:
- Removing the need to clear the bar's surface when it's drawn. Borders
  will now only clear the part of the bar covered by those borders.
- Similarly, filling any bar space no occupied by widgets will only draw
  in that space.

Run Details

25 of 25 new or added lines in 3 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

14043 of 18883 relevant lines covered (74.37%)

2.23 hits per line