qtile / qtile
79%

DEFAULT BRANCH: master
Repo Added
Files 154
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x

coverage: 78.945% (-0.04%) from 78.987%
17431853464

push

github

tych0 
widget: don't return an error when calculating length

If a widget's length calculation has a bug and raises an exception, we
silently swallow it via @property, and it shows up as an AttributeError:

    2025-09-02 20:26:46,949 ERROR libqtile loop.py:_handle_exception():L62 Exception in event loop:
    Traceback (most recent call last):
      File "/usr/lib/python3.13/asyncio/events.py", line 89, in _run
        self._context.run(self._callback, *self._args)
        ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/lib/python3.13/site-packages/libqtile/core/manager.py", line 997, in f
        func(*args)
        ~~~~^^^^^^^
      File "/usr/lib/python3.13/site-packages/libqtile/bar.py", line 622, in _actual_draw
        self._resize(self._length, self.widgets)
        ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/lib/python3.13/site-packages/libqtile/bar.py", line 465, in _resize
        stretchspace = length - sum(i.length for i in widgets if i.length_type != STRETCH)
                                ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/lib/python3.13/site-packages/libqtile/bar.py", line 465, in <genexpr>
        stretchspace = length - sum(i.length for i in widgets if i.length_type != STRETCH)
                                    ^^^^^^^^
      File "/usr/lib/python3.13/site-packages/libqtile/command/base.py", line 283, in __getattr__
        raise AttributeError(f"{self.__class__} has no attribute {name}")
    AttributeError: <class 'libqtile.widget.groupbox.GroupBox'> has no attribute length. Did you mean: '_length'?

Let's catch these exceptions and log them, so we can try and fix these
problems.

Signed-off-by: Tycho Andersen <tycho@tycho.pizza>

2 of 5 new or added lines in 1 file covered. (40.0%)

68 existing lines in 2 files now uncovered.

17113 of 21677 relevant lines covered (78.95%)

4.21 hits per line

Relevant lines Covered
21677 RELEVANT LINES 17113 COVERED LINES
4.21 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
17431853464 master widget: don't return an error when calculating length If a widget's length calculation has a bug and raises an exception, we silently swallow it via @property, and it shows up as an AttributeError: 2025-09-02 20:26:46,949 ERROR libqtile loop... push tych0 github
78.95
17430937570 log-upgrades Merge 5a14878c3 into 09d4af3d2 Pull #5488 web-flow github
78.95
17430874137 log-upgrades Merge a178c3fa4 into 09d4af3d2 Pull #5488 web-flow github
78.96
17427452588 wayc-rtd2 Merge ca83c32c5 into 01d9e4621 Pull #5486 web-flow github
81.36
17427226212 wayc-rtd2 Merge 5826db690 into 01d9e4621 Pull #5486 web-flow github
81.36
17426497466 wayc Update MANIFEST.in Pull #5485 jwijenbergh github
81.38
17425884434 fix-manifest-errors Merge 3eccd9057 into 35081a7cc Pull #5487 web-flow github
81.38
17404233766 master Add py3.14-dev to CI push tych0 github
78.99
17399754688 ci-314 Merge 221dd4dc6 into 5c27b6a35 Pull #5466 web-flow github
78.97
17399191481 ci-314 Merge 6d79d80d9 into 5c27b6a35 Pull #5466 web-flow github
78.97
See All Builds (5058)