PrincetonUniversity / PsyNeuLink / 6006863846

85%

master: 85%

push

github-actions

Feat/models/ego mdp (#2789)

• EGO Model - MDP
  - refactor to not use counter or response layers

• composition.py
  - _parse_receiver_spec(): modify error message for missing receiver to include name of offending Projection

* • composition.py
  - test_composition.py
    - TestAddProjection:
      - restore test for parallel projections between two nodes
      - modify error msg for receiver not specified
      - add test for received node not in comp

* • memoryfunctions.py
  ContentAddressableMemory._validate(): modify error message for scalar fields


• EGO Model - MDP
  - refactor attention into two layers

• controlmechanism.py
  _outcome_getter:  cast return value as dtype=object since it can be an irregular array

• memoryfunctions.py
  - ContentAddressableMemory:
    - add _distance_field_weights_setter that checks if non-zero/non-None weight is assigned to field with scalar when COSINE is used as similarity metric

• EGO Model - MDP:
  include parameters from Python model
  fuller implementation of environment

• controlmechanism.py
  - _instantiate_input_ports &   _parse_monitor_for_control:  handle FEEDBACK spec (though should be moved to Port._parse_port_spec)

• composition.py
  - add_projection: handle feedback attribute specified on Projection (still needs to be integrated with assignment of FEEDBACK_SENDER and FEEDBACK_RECEIVER NodeRoles)

  • projection.py
    - add feedback as constructor argument and attribute

• implement feedback specification in port_spec


---------

Co-authored-by: jdcpni <pniintel55>

12788 of 15884 branches covered (0.0%)

Branch coverage included in aggregate %.

54 of 54 new or added lines in 6 files covered. (100.0%)

30868 of 35706 relevant lines covered (86.45%)

0.86 hits per line