kivy / buildozer / 5984602626

0%

push

github

Use buildops for file_exists and file_matches (#1670)

This is part of a larger refactor, to reduce the size and complexity of the Buildozer class.

* Remove `file_matches()` method from the Buildozer class.
* Change the singular reference to it in `android.py` to use the buildops function.
   * This raises the question: Will this be useful to other targets in the future, or should this be moved into the android target? Left for future refactors.

* Remove the `file_exists()` method from the Buildozer class.
* Change all the references to use the buildops function.
   * Note for consistency with the other buildop functions, buildops.file_exists() takes a single parameter rather than `*args` and doesn't join the path together. One client call needed to be changed to accommodate that.
   * Note that in several places, the code checks for the existence of *directories* with os.path.exists(). I did **not** change these over because:
     * Historically, the name as been **file**_exists().
     * With the join statement removed, this function doesn't add anything to calling `os.path.exists()` or `pathlib.Path.exists()`, so enforcing it on the code seemed counter-productive. I went with for consistency with existing code.
* Update mocks

448 of 1211 branches covered (0.0%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 4 files covered. (100.0%)

1385 of 2861 relevant lines covered (48.41%)

3.61 hits per line