kivy / buildozer / 5983657674

0%

push

github

Migrate to use Buildop's rmtree, file_copy, file_copytree and rename (#1669)

* Migrate to use Buildop's rmtree, file_copy, file_copytree and rename

This is part of a bigger refactor to reduce the size and complexity of the Buildozer class. It adds no new functionality (apart from making logging more consistent)

* Remove file_rename, file_copy and file_copytree from Buildozer.
* Update all references to those Buildozer methods to refer to buildops equivalents.
   * Note: `file_rename` is now called rename as, in practice, it was also used to rename directories.
* Updated all references to shutil.copyfile and shutil.rmtree to use the Buildops equivalents
  * Note this adds implicit debug logging, making them more consistent.
* Updated all references to check_call() and check_output() that called the `rm` and `cp` shell commands.
  * Note this adds implicit debug logging, making them more consistent, and improves performance.
* Updated mock in test.

Cheekily, also removed some obsolete references to Python 2 (only) standard libraries to make my IDE stop warning me about them while I edited the file.

* Fixed missed file_rename reference in IOS

427 of 1106 branches covered (0.0%)

Branch coverage included in aggregate %.

26 of 26 new or added lines in 5 files covered. (100.0%)

1333 of 2713 relevant lines covered (49.13%)

3.98 hits per line