Khan
/
perseus
/
5895941529
69%
|
Ran
|
Jobs
2
|
Files
530
|
Run time
83min
|
Badge
Embed ▾
README BADGES
|
coverage: 69.348% (+0.02%) from 69.327%
push
github
web-flowRevert "Roll v2 Keypad Onto Desktop Web (#645)" to unblock release while making focus changes (#675) This reverts commit e036092e8. On August 17, a few conversations were had that led to the following plan of attack for Keypad focus handling: https://khanacademy.slack.com/archives/C8XGW76FQ/p1692301859002839?thread_ts=1692120760.613379&cid=C8XGW76FQ While we make the necessary changes to Keypad and then to the expression widget, reverting this to keep Perseus releasable. Author: nedredmond Reviewers: jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ gerald, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x) Pull Request URL: https://github.com/Khan/perseus/pull/675
7612 of 16572 branches covered (45.93%)
Branch coverage included in aggregate %.
175 of 216 new or added lines in 5 files covered. (81.02%)
3 existing lines in 2 files now uncovered.71273 of 97180 relevant lines covered (73.34%)
711.43 hits per line
New Missed Lines in Diff
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 4 |
80.7 |
2.25% | packages/perseus/src/components/math-input.tsx |
| 6 |
43.08 |
0.0% | packages/perseus-editor/src/widgets/expression-editor.tsx |
| 6 |
21.53 |
-0.94% | packages/perseus-editor/src/widgets/interaction/constraint-editor.tsx |
| 25 |
9.01 |
-0.15% | packages/perseus-editor/src/widgets/interaction-editor.tsx |
Uncovered Existing Lines
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
80.0 |
-4.0% | packages/math-input/src/components/keypad/utils.ts |
| 2 |
73.64 |
-0.78% | packages/perseus/src/jquery.mobile.vmouse.js |
Subprojects
| ID | Flag name | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|---|
| 1 | cypress | 5895941529.1 | 368 |
26.16 |
GitHub Action Run | |
| 2 | jest | 5895941529.2 | 525 |
63.27 |
GitHub Action Run |
