• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Khan / perseus / 5894689965
69%

Build:
DEFAULT BRANCH: main
Ran 17 Aug 2023 06:42PM UTC
Jobs 2
Files 530
Run time 130min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

17 Aug 2023 06:38PM UTC coverage: 69.327% (+0.02%) from 69.306%
5894689965

push

github

web-flow
Add Fraction Keypad View (#667)

## Summary:
Added the fraction keypad view to the new v2 keypad as part of our overhaul of MathInput. This fraction view is used by the following Perseus Widgets:

- InputNumber
- Matrix
- NumberLine
- NumericInput
- Table

I've also updated existing stories to be able to demonstrate this new view. As it turns out, we're not doing anything custom with our numberpad page for the Fraction Keypad, so we can reuse the preexisting page. 

Note: I've settled on the prop name of "fractionsOnly" but I am open to any suggestions on a more descriptive name. I felt "fractionsOnly" was the closest I could get to a balance of being descriptive against the tab props, yet brief. 

## Screenshots:
(Forcing the "IN_NUMERATOR" calculator context in the _Full Mobile MathInput_ Story to show the context button)
![Screenshot 2023-08-15 at 3 43 51 PM](https://github.com/Khan/perseus/assets/12463099/16dc4ca1-a1ba-4cbc-85e6-86ed3678b644)

(No cursor context using _Full Keypad_ Story)
![Screenshot 2023-08-15 at 3 40 34 PM](https://github.com/Khan/perseus/assets/12463099/ffa3ce6c-057a-4146-8d5c-2984098535d5)

(Based on our [Figma Designs](https://www.figma.com/file/2lUPOSbOP8tbW7RLqbBFLh/Expression-Widget?type=design&node-id=4674-87332&mode=design&t=gZTp9zvbYilUKfYa-0))

Issue: LC-1098

## Test plan:
- manual testing
- new stories

Author: SonicScrewdriver

Reviewers: handeyeco, SonicScrewdriver

Required Reviewers:

Approved By: handeyeco, handeyeco

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/667

7606 of 16610 branches covered (45.79%)

Branch coverage included in aggregate %.

206 of 254 new or added lines in 7 files covered. (81.1%)

71304 of 97213 relevant lines covered (73.35%)

714.87 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
13
0.0
0.0% packages/math-input/src/components/keypad/keypad.stories.tsx
35
0.0
0.0% packages/math-input/src/full-math-input.stories.tsx
Subprojects
ID Flag name Job ID Ran Files Coverage
1 cypress 5894689965.1 17 Aug 2023 06:42PM UTC 368
26.14
GitHub Action Run
2 jest 5894689965.2 17 Aug 2023 06:48PM UTC 525
63.21
GitHub Action Run
Source Files on build 5894689965
  • Tree
  • List 530
  • Changed 26
  • Source Changed 0
  • Coverage Changed 7
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • b93f9f74 on github
  • Prev Build on main (#5881314455)
  • Next Build on main (#5895941529)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc