#37591
77%

Ran 31 Jul 2023 01:29PM UTC

Jobs 1

Files 343

Run time 9s

Badge

Embed ▾

pending completion

Build # #37591

Build Type

push

local

Committed by

web-flow

Commit Message

Allocation Profiler: Types for all allocations (#50337)

Pass the types to the allocator functions.

-------

Before this PR, we were missing the types for allocations in two cases:

1. allocations from codegen
2. allocations in `gc_managed_realloc_`

The second one is easy: those are always used for buffers, right?

For the first one: we extend the allocation functions called from
codegen, to take the type as a parameter, and set the tag there.

I kept the old interfaces around, since I think that they cannot be
removed due to supporting legacy code?

------

An example of the generated code:
```julia
  %ptls_field6 = getelementptr inbounds {}**, {}*** %4, i64 2
  %13 = bitcast {}*** %ptls_field6 to i8**
  %ptls_load78 = load i8*, i8** %13, align 8
  %box = call noalias nonnull dereferenceable(32) {}* @ijl_gc_pool_alloc_typed(i8* %ptls_load78, i32 1184, i32 32, i64 4366152144) #7
```

Fixes #43688.
Fixes #45268.

Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>

Run Details

72755 of 84117 relevant lines covered (86.49%)

22738368.36 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	89.34	-0.31%	base/boot.jl
1	97.3	-0.68%	base/char.jl
1	90.0	-5.45%	base/docs/bindings.jl
1	89.58	-1.14%	base/error.jl
1	84.62	-0.55%	base/indices.jl
1	84.77	-0.39%	base/promotion.jl
1	94.86	0.05%	base/range.jl
1	99.04	1.28%	base/rational.jl
1	87.97	-0.05%	base/show.jl
1	91.57	-0.38%	base/strings/search.jl
1	86.24	-0.92%	stdlib/Markdown/src/parse/util.jl
1	85.19	-2.09%	stdlib/Profile/src/Allocs.jl
1	87.57	-0.14%	stdlib/REPL/src/REPLCompletions.jl
2	48.39	-2.15%	base/multimedia.jl
2	92.55	1.25%	stdlib/LinearAlgebra/src/factorization.jl
3	97.48	-1.26%	base/bitset.jl
3	76.47	-3.53%	base/experimental.jl
4	75.0	-1.32%	base/client.jl
4	89.9	-4.04%	stdlib/Distributed/src/workerpool.jl
4	82.35	-7.84%	stdlib/Markdown/src/parse/parse.jl
4	90.48	-9.52%	stdlib/Markdown/src/render/terminal/formatting.jl
5	98.08	0.0%	base/special/trig.jl
5	87.89	-2.63%	stdlib/Markdown/src/Common/block.jl
6	53.33	-40.0%	stdlib/Markdown/src/IPython/IPython.jl
7	44.66	-1.58%	base/util.jl
7	87.68	-1.01%	stdlib/Profile/src/Profile.jl
8	67.07	-4.79%	base/combinatorics.jl
8	21.43	-57.14%	base/docs/core.jl
8	64.0	-32.0%	base/docs/utils.jl
8	87.3	0.0%	base/mpfr.jl
8	59.26	-29.63%	base/ryu/Ryu.jl
9	15.38	-72.85%	stdlib/Markdown/src/Markdown.jl
10	81.94	-0.17%	base/loading.jl
11	95.82	0.01%	stdlib/LinearAlgebra/src/generic.jl
12	82.25	-2.88%	base/task.jl
13	62.5	-1.56%	base/Base.jl
13	89.48	-0.02%	base/float.jl
13	52.55	0.65%	base/timing.jl
15	84.48	0.45%	base/partr.jl
17	84.03	0.92%	stdlib/LinearAlgebra/src/adjtrans.jl
19	68.13	-20.88%	stdlib/Logging/src/ConsoleLogger.jl
22	21.21	-66.67%	stdlib/Markdown/src/Julia/interp.jl
25	79.38	-2.98%	stdlib/InteractiveUtils/src/InteractiveUtils.jl
26	85.53	-8.22%	base/expr.jl
29	74.6	-7.67%	base/ryu/shortest.jl
32	61.07	-21.48%	base/ryu/fixed.jl
34	64.24	0.0%	base/libc.jl
37	53.04	-32.17%	stdlib/Markdown/src/GitHub/table.jl
39	45.0	-28.61%	base/meta.jl
39	54.59	-17.03%	base/ryu/utils.jl
45	38.74	-40.54%	stdlib/Markdown/src/render/terminal/render.jl
51	36.36	-57.95%	stdlib/Markdown/src/render/plain.jl
52	38.3	-46.08%	base/libdl.jl
53	38.38	-53.54%	stdlib/Markdown/src/render/html.jl
56	53.94	-23.79%	base/docs/Docs.jl
66	78.8	-13.02%	stdlib/REPL/src/docview.jl
70	91.37	0.21%	stdlib/LinearAlgebra/src/triangular.jl
152	64.88	-24.77%	base/errorshow.jl
277	30.58	-44.82%	stdlib/Printf/src/Printf.jl

Jobs

ID	Job ID	Ran	Files	Coverage
1	#37591.1	31 Jul 2023 01:29PM UTC	343	86.49

JuliaLang / julia / #37591
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #37591

JuliaLang / julia / #37591 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #37591

JuliaLang / julia / #37591
77%

README BADGES
x