blues / note-c / 5248613519

93%

push

github

feat: add automatic crc support, supported by notecard firmware as of 2023-06-10 (#74)

* add automatic crc support, supported by notecard firmware as of 2023-06-10

* fix off-by-one in malloc length; change stm32duino default i2c length

* rename funcs so not in conflict with user app

* fix exception

* fix: Unit-tests

- Improve error logging on failure
- Change call count to greater than 1 (ensure invocation not count)

* chore: Refactor #defines

* Make some changes/fixes to CRC code for NoteTransaction.

- Simplify code to get rid of need for lastRequestCrcAdded.
- Fail NoteTransaction if CRC needed to be added and it wasn't.
- Make sure that if there was a CRC or I/O error even after retrying that
NoteTransaction returns an error.
- Add a unit test for crcAdd.
- Add a unit test for crcError.
- Add additional tests to NoteTransaction_test.cpp for CRC and I/O error cases.

---------

Co-authored-by: Zachary J. Fields <zachary_fields@yahoo.com>
Co-authored-by: Hayden Roche <hroche@blues.com>

788 of 965 branches covered (81.66%)

Branch coverage included in aggregate %.

1649 of 1755 relevant lines covered (93.96%)

15.1 hits per line