Ouranosinc / xclim / 5204489568

90%

main: 90%

Build Type

push

github

Committed by web-flow

Commit Message

Faster escore (#1383)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGES.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* correlation functions in `_escore` now have an additional loop that
basically replaces the numpy operation: `v1[:] - v2[:]`. This makes the
function run much faster (~ 30 times faster)

### Does this PR introduce a breaking change?

No

### Other information:

There are some instances where nopython has a harder time for some numpy
functions:
https://stackoverflow.com/questions/42846313/numba-nopython-mode-slower-than-object-mode,
this could be related.

Run Details

0 of 8 new or added lines in 1 file covered. (0.0%)

2 existing lines in 1 file now uncovered.

7819 of 8634 relevant lines covered (90.56%)

2.62 hits per line