safe-global / safe-client-gateway-nest / 5142568745

92%

push

github

Fix SafeApp entity, schema, and service mappings (#383)

Closes #338 

This PR:
- Adds `developerWebsite` and `socialProfiles` properties to `SafeApp`
route entity, and adjust related mappings, schemas, and test builders.
- Adjust `SafeAppAccessControl` to include a nullable `value` ([Rust
implementation
ref](https://github.com/safe-global/safe-client-gateway/blob/e0d69faab/src/routes/safe_apps/models.rs#L43)).
- `SafeAppAccessControl.value` returns an array of URIs (if provided)
when `SafeAppAccessControl.type` is `DOMAIN_ALLOWLIST`.
- `SafeAppAccessControl.type` is `UNKNOWN` when the value received from
the Config Service is different from `DOMAIN_ALLOWLIST` or
`NO_RESTRICTIONS`.
- Adapts the related unit/e2e tests.
- Adapts the OpenApi specification to the new properties.

859 of 1034 branches covered (83.08%)

Branch coverage included in aggregate %.

4057 of 4299 relevant lines covered (94.37%)

41.96 hits per line