safe-global / safe-client-gateway-nest / 5134977281

92%

Build Type

push

github

Committed by web-flow

Commit Message

Fix TransactionData addressInfoIndex property differences (#381)

Closes
https://github.com/safe-global/safe-client-gateway-nest/issues/362 and
https://github.com/safe-global/safe-client-gateway-nest/issues/367

This PR:
- Fixes the legacy Rust implementation differences by avoiding
traversing the `dataDecoded` with an arbitrary depth size. This fix
makes the service only get results from the first level (as the Rust
implementation does).
- For the items contained in `addressInfoIndex`, the associated
`AddressInfo` is retrieved from `Token`, and from `Contract` as a
fallback. Then, `AddressInfo` with no `name` property are filtered out.
(to meet the legacy behavior)
- Unifies the `txData.addressInfoIndex` response as a non-empty object,
or `null`.

Run Details

851 of 1029 branches covered (82.7%)

Branch coverage included in aggregate %.

22 of 25 new or added lines in 1 file covered. (88.0%)

2 existing lines in 1 file now uncovered.

4022 of 4264 relevant lines covered (94.32%)

41.45 hits per line