#37333
85%

Ran 11 Nov 2022 11:38AM UTC

Jobs 1

Files 386

Run time 21s

Badge

Embed ▾

pending completion

Build # #37333

Build Type

push

local

Committed by

web-flow

Commit Message

Dates: Error on construction/parsing with empty strings (#47117)

When attempting to construct a `DateTime`, `Date` or `Time` from an
`AbstractString`, throw an `ArgumentError` if the string is empty.
Likewise, error when `parse`ing an empty string as one of these types,
and return `nothing` from `tryparse`.

This behavior differs from previously.  Before, `Date` and `Time` would
return default values of `Date(1)` and `Time(0)`, respectively, while
`DateTime` would error without a `format` argument.  With a `format`
argument, it would return `DateTime(1)`.  However, this appears not to
have been explicitly intended, but rather a consequence of the way
parsing was implemented; no tests for empty string parsing existed.

This addresses #28090 and #43883; see discussion therein.

Summary of changes:
- Check for empty string in `Base.parse(::DateTime)` and throw if so.
- Change documentation to mention this.
- Add a compat notice to the docs contrasting the old behavior.

Run Details

80818 of 86597 relevant lines covered (93.33%)

33015200.56 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	95.08	0.18%	compiler/ssair/inlining.jl
1	87.41	-0.37%	compiler/ssair/irinterp.jl
1	78.89	0.0%	compiler/ssair/ir.jl
1	91.51	0.21%	compiler/ssair/passes.jl
1	93.75	-3.13%	compiler/stmtinfo.jl
1	84.62	-1.28%	experimental.jl
1	92.59	1.23%	indices.jl
1	92.12	-0.41%	logging.jl
1	96.51	0.29%	multidimensional.jl
1	92.59	1.57%	process.jl
1	95.83	-4.17%	some.jl
2	81.34	-0.7%	client.jl
2	90.0	4.52%	libdl.jl
2	97.95	0.9%	reduce.jl
3	94.59	-0.18%	show.jl
9	91.37	-0.46%	compiler/abstractinterpretation.jl
14	97.34	23.62%	bitarray.jl
17	89.8	-3.36%	gmp.jl
20	90.09	-1.67%	loading.jl
127	68.21	-23.61%	errorshow.jl

Jobs

ID	Job ID	Ran	Files	Coverage
1	#37333.1	11 Nov 2022 11:38AM UTC	386	93.33

JuliaLang / julia / #37333
85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #37333

JuliaLang / julia / #37333 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #37333

JuliaLang / julia / #37333
85%

README BADGES
x