9365
0%
main: 93%

Ran 08 Mar 2016 08:38PM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 9365

Build Type

push

travis-ci

Committed by

patricklaw

Commit Message

[bugfix] Properly opt out of zinc's fingerprinting of Resources.

Properly opt out of zinc's fingerprinting of Resources.

Internally at Foursquare we have a task that injects a Resource
target dependency on every JvmLibrary in the graph (a temporary
hack), and we noticed that this task getting scheduled before
compilation vs after compilation results in totally different
fingerprints for the entire graph (wrt zinc's FP strategy).
This is because the FP strategy isn't using the mechanism to opt
out of fingerprinting a target (return `None`)--therefore even
though the resource target's contents aren't rolled into the fingerprint,
the resource target's presence in the graph affects the transitive
fingerprints of dependees.

It's plausible that we want to go further here and opt out of
fingerprinting anything except `JvmTarget` and `JarLibrary` subclasses
here, since in theory all other dependencies are extraneous and irrelevant
from zinc's perspective.

Testing Done:
CI is green: https://travis-ci.org/pantsbuild/pants/builds/114591351

Bugs closed: 2632

Reviewed at https://rbcommons.com/s/twitter/r/3185/

Coverage Stats

Jobs

ID	Job ID	Ran
1	9365.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	08 Mar 2016 08:38PM UTC	Travis Job 9365.1
4	9365.4 (CI_FLAGS="-fkmsrcjlpa 'Python contrib tests'")	08 Mar 2016 09:00PM UTC	Travis Job 9365.4
5	9365.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	08 Mar 2016 08:49PM UTC	Travis Job 9365.5
6	9365.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	08 Mar 2016 08:55PM UTC	Travis Job 9365.6
7	9365.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	08 Mar 2016 09:00PM UTC	Travis Job 9365.7
8	9365.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	08 Mar 2016 09:03PM UTC	Travis Job 9365.8
10	9365.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	08 Mar 2016 09:07PM UTC	Travis Job 9365.10

Source Files on build 9365

Detailed source file information is not available for this build.

pantsbuild / pants / 9365
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9365

pantsbuild / pants / 9365 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9365

pantsbuild / pants / 9365
0%
main: 93%

README BADGES
x