9354
0%
main: 93%

Ran 08 Mar 2016 06:56AM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 9354

Build Type

push

travis-ci

Committed by

peiyuwang

Commit Message

[engine] switch content addressable storage from dict to a embedded db

This review switches to use a lmdb db for our content addressable storage.

* Moved `SubjectKey` and `Subjects` to `storage` module, they serve as the public interface as content addressable storage, the rest in `storage` are private.
* Removed `SubjectKey.len()`, not applicable to the db kvs implementation.
* Introduce `Closable` to handle db clean up, more convenient for the long running use case, clean up is done at the end of process. The context management protocol is also provided.
* No change to `StepContext` which is still needed for nodes to access subjects, just a different implementation of subjects.
* No change to `StepRequest`
* Simplified `StepResult` because now there is no need to pass subjects back to the scheduler, as well as the code to handle that.
* `StatefulPool` initial state is now bootstrapped via a function that acquires db handle for the process (as opposed to passing the db)

Testing Done:
https://travis-ci.org/peiyuwang/pants/builds/112928418 passed
https://travis-ci.org/peiyuwang/pants/builds/113232665 passed
https://travis-ci.org/peiyuwang/pants/builds/114440248 passed

Bugs closed: 2968

Reviewed at https://rbcommons.com/s/twitter/r/3517/

Coverage Stats

Jobs

ID	Job ID	Ran
1	9354.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	08 Mar 2016 06:56AM UTC	Travis Job 9354.1
4	9354.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	08 Mar 2016 07:05AM UTC	Travis Job 9354.4
6	9354.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	08 Mar 2016 07:05AM UTC	Travis Job 9354.6
7	9354.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	08 Mar 2016 07:05AM UTC	Travis Job 9354.7
8	9354.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	08 Mar 2016 07:08AM UTC	Travis Job 9354.8
9	9354.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	08 Mar 2016 07:08AM UTC	Travis Job 9354.9
10	9354.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	08 Mar 2016 07:17AM UTC	Travis Job 9354.10

Source Files on build 9354

Detailed source file information is not available for this build.

pantsbuild / pants / 9354
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9354

pantsbuild / pants / 9354 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9354

pantsbuild / pants / 9354
0%
main: 93%

README BADGES
x