#37299
77%

Ran 12 Oct 2022 11:31AM UTC

Jobs 1

Files 383

Run time 14s

Badge

Embed ▾

pending completion

Build # #37299

Build Type

push

local

Committed by

web-flow

Commit Message

Do not use `Stateful` for `cmp` of `AbstractString` (#47125)

PR #45924 fixed length of `Stateful`, but this change requires `Stateful` to call
`length` on its wrapped iterator on instantiation.
The current implementation of `cmp(::AbstractString, ::AbstractString)` wraps the
strings in `Stateful` to efficiently check if one string is longer than the other
without needing an O(N) call to `length`.
However, with #45924 this length call is done anyway, which led to a performance
regression.

In this PR, the `cmp` method is changed so it no longer relies on `Stateful` to do
the same thing.

Fix #46719

Run Details

80671 of 86327 relevant lines covered (93.45%)

31455242.24 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	#37299.1	12 Oct 2022 11:31AM UTC	0	93.45

Source Files on build #37299

Detailed source file information is not available for this build.

JuliaLang / julia / #37299
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #37299

JuliaLang / julia / #37299 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #37299

JuliaLang / julia / #37299
77%

README BADGES
x