9246
0%
main: 93%

Ran 02 Mar 2016 08:19PM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 9246

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Clone jars rather than mutating them during ivy resolve

The excludes (for 'provided'/round-trip deps) added to jars during ivy resolve are only useful in that scope, but because they remain in the graph, they can end up affecting the excludes written during `./pants publish` (and probably also the runtime performance of classpath calculation).

- Made JarDependency immutable by extending `datatype`
- Switched mutators to the `jar.copy(**replacements)` API
- Fixup the build dictionary to support `namedtuple`/`datatype` subclasses, which don't have `__init__`

While this is technically a breaking change, I think it's easy to make an argument for closing a loophole that allows for strange sideeffects in the build graph.

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/113190835

Bugs closed: 2655

Reviewed at https://rbcommons.com/s/twitter/r/3203/

Coverage Stats

Jobs

ID	Job ID	Ran
1	9246.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	02 Mar 2016 08:19PM UTC	Travis Job 9246.1
4	9246.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	02 Mar 2016 08:40PM UTC	Travis Job 9246.4
5	9246.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	02 Mar 2016 08:20PM UTC	Travis Job 9246.5
6	9246.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	02 Mar 2016 08:28PM UTC	Travis Job 9246.6
8	9246.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	02 Mar 2016 08:30PM UTC	Travis Job 9246.8
9	9246.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	02 Mar 2016 08:31PM UTC	Travis Job 9246.9
10	9246.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	02 Mar 2016 08:34PM UTC	Travis Job 9246.10

Source Files on build 9246

Detailed source file information is not available for this build.

pantsbuild / pants / 9246
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9246

pantsbuild / pants / 9246 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9246

pantsbuild / pants / 9246
0%
main: 93%

README BADGES
x