9184
0%
main: 93%

Ran 27 Feb 2016 12:52AM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 9184

Build Type

push

travis-ci

Committed by

baroquebobcat

Commit Message

Change ivy resolve ordering to attempt load first and fall back to full resolve if load fails.

I've been working on splitting resolve into a resolve and fetch. This patch backports the structural approach I've ended up with. In it, we bias towards the faster, loading paths first, checking for their preconditions and falling through to the calling out to ivy paths if they aren't met.

The current implementation instead checks to see if work is needed, then falls through to loading if it is not. The problem with that approach is that if it turns out that the loaded resolve is incomplete, we can't complete it--we'll blow up somewhere later. This problem would become bigger with more potential loading and resolving paths. Moving to the new model makes adding more loading and resolving mechanisms easier.

- Move ivy reports to resolve workdir after successful resolves.
- Introduce class to encapsulate the result of a ivy resolve.
- Fall back to a full resolve when any ivy symlink points to a missing file.
- Bump the implementation version.
- Make parsing an Ivy report via a path public.
- Update docstrings for resolve and ivy_classpath.

Testing Done:
Running jvm tests in a large subgraph locally. CI passed at https://travis-ci.org/pantsbuild/pants/builds/112160887

Bugs closed: 2967

Reviewed at https://rbcommons.com/s/twitter/r/3501/

closes #2967

Coverage Stats

Jobs

ID	Job ID	Ran
1	9184.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	27 Feb 2016 12:58AM UTC	Travis Job 9184.1
4	9184.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	27 Feb 2016 01:03AM UTC	Travis Job 9184.4
5	9184.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	27 Feb 2016 12:52AM UTC	Travis Job 9184.5
6	9184.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	27 Feb 2016 01:06AM UTC	Travis Job 9184.6
7	9184.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	27 Feb 2016 01:12AM UTC	Travis Job 9184.7
9	9184.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	27 Feb 2016 01:15AM UTC	Travis Job 9184.9
10	9184.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	27 Feb 2016 01:14AM UTC	Travis Job 9184.10

Source Files on build 9184

Detailed source file information is not available for this build.

pantsbuild / pants / 9184
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9184

pantsbuild / pants / 9184 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9184

pantsbuild / pants / 9184
0%
main: 93%

README BADGES
x