#912
93%

Ran 24 Aug 2022 01:53AM UTC

Jobs 1

Files 73

Run time 3s

Badge

Embed ▾

pending completion

Build # #912

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Generalize handler APIs for argument nullability on (un-)annotated code. (#639)

In particular, this allows library models to change the nullability of method
arguments in annotated code.

This change replaces two separate an overly specific `Handler` callbacks:

- `onUnannotatedInvocationGetExplicitlyNullablePositions`
- `onUnannotatedInvocationGetNonNullPositions`

With a single more general callback:

- `onOverrideMethodInvocationParametersNullability`

which is explicitly meant to handle overriding/changing method parameter 
nullability for both annotated and unannotated code (thus solving issue #637).

This requires some refactoring (mostly simplifying logic) in the core NullAway 
class, as well as changes to the different handlers, which must now explicitly 
skip annotated code if they aren't designed to work with it (e.g. 
`RestrictiveAnnotationHandler`).

Run Details

4825 of 5219 relevant lines covered (92.45%)

0.92 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	91.67	0.0%	../nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
1	97.06	-0.31%	../nullaway/src/main/java/com/uber/nullaway/handlers/RestrictiveAnnotationHandler.java
3	99.41	0.01%	../nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java
24	81.58	-0.18%	../nullaway/src/main/java/com/uber/nullaway/handlers/InferredJARModelsHandler.java
26	95.45	0.03%	../nullaway/src/main/java/com/uber/nullaway/NullAway.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#912.1	24 Aug 2022 01:53AM UTC	73	92.45

uber / NullAway / #912
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #912

uber / NullAway / #912 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #912

uber / NullAway / #912
93%

README BADGES
x