#910
93%

Ran 24 Aug 2022 12:30AM UTC

Jobs 1

Files 73

Run time 4s

Badge

Embed ▾

pending completion

Build # #910

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Support for Map.computeIfAbsent(...) (#640)

This method should be treated as `Map.put(...)`, with the caveat that we need 
to check if the `Function<K, V>` passed to `computeIfAbsent(...)` can return a 
`@Nullable V`, rather than just checking for the nullness of the argument 
itself.

Without full support for nullability of type parameters, we can't check that we 
are dealing with `Function<K, V>` vs `Function<K, @Nullable V>` in the general 
case. For usability, we default to marking the map key access path as non-null 
if `computeIfAbsent(...)` is called for that key. We add a few sanity checks, 
but as the test cases show, those checks _can_ be incomplete. In practice, we 
expect `computeIfAbsent(...)` to compute a non-null value in all but extremely 
rare instances, but long-term it would be ideal if we could properly check this.

Run Details

4812 of 5205 relevant lines covered (92.45%)

0.92 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
4	95.77	-1.04%	../nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPath.java
32	89.94	-0.48%	../nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPathNullnessPropagation.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#910.1	24 Aug 2022 12:30AM UTC	73	92.45

uber / NullAway / #910
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #910

uber / NullAway / #910 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #910

uber / NullAway / #910
93%

README BADGES
x