pantsbuild / pants / 9138
0%
main: 93%

LAST BUILD BRANCH: pantsd/stdio-per-run-log
DEFAULT BRANCH: main
Ran
Jobs 7
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
9138

push

travis-ci

stuhood 
Add [GLOBAL] in pants.ini for pants global options; Add config file validations against options

Earlier [DEFAULT] is used to store both variables and global options. This change, though still allows pants global options in [DEFAULT], adds the flexibility for them to move to [PANTS_GLOBAL] where variables are disallowed.

Testing Done:
https://travis-ci.org/wisechengyi/pants/builds/111318743

```
[tw-mbp-yic pants (pants_globals)]$ cat test.ini
[options]
colors: False
[yolo]
good: True
bad: False
[test.junit]
hello_world: 123
byebye: True

[tw-mbp-yic pants (pants_globals)]$ ./pants --config-override=test.ini --verify-config goals
ERROR] Invalid scope [yolo] in test.ini
ERROR] Invalid option 'hello_world' under [test.junit] in test.ini
ERROR] Invalid option 'byebye' under [test.junit] in test.ini
Exception caught: (<class 'pants.option.errors.OptionsError'>)
  File "/Users/yic/workspace/pants/src/python/pants/bin/pants_exe.py", line 50, in <module>
    main()
  File "/Users/yic/workspace/pants/src/python/pants/bin/pants_exe.py", line 44, in main
    PantsRunner(exiter).run()
  File "/Users/yic/workspace/pants/src/python/pants/bin/pants_runner.py", line 53, in run
    options_bootstrapper=options_bootstrapper)
  File "/Users/yic/workspace/pants/src/python/pants/bin/pants_runner.py", line 43, in _run
    return LocalPantsRunner(exiter, args, env, options_bootstrapper=options_bootstrapper).run()
  File "/Users/yic/workspace/pants/src/python/pants/bin/local_pants_runner.py", line 49, in run
    self._maybe_profiled(self._run)
  File "/Users/yic/workspace/pants/src/python/pants/bin/local_pants_runner.py", line 46, in _maybe_profiled
    runner()
  File "/Users/yic/workspace/pants/src/python/pants/bin/local_pants_runner.py", line 55, in _run
    options, build_config = OptionsInitializer(options_bootstrapper, exiter=self._exiter).setup()
  File "/Users/yic/workspace/pants/src/python/pants/bin/goal_runner.py", line 135, in setup
    return self._setup_options(self._options_bootstrapper, self._working_set)
  File "/Users/yic/workspace/pants/src/python/pants/bin/goal_runner.py", line 130, in _setup_options
    options_bootstrapper.verify_configs_against_options(options)
  File "/Users/yic/workspace/pants/src/python/pants/option/options_bootstrapper.py", line 152, in verify_configs_against_options
    raise OptionsError("Invalid config entries detected. See log for details.")

Exception message: Invalid config entries detected. See log for details.
```

Bugs closed: 1803

Reviewed at https://rbcommons.com/s/twitter/r/3475/
Jobs
ID Job ID Ran Files Coverage
1 9138.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 9138.1
4 9138.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 9138.4
5 9138.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 9138.5
6 9138.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 9138.6
8 9138.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 9138.8
9 9138.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 9138.9
10 9138.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 9138.10
Source Files on build 9138
Detailed source file information is not available for this build.