9126
0%
main: 93%

Ran 22 Feb 2016 05:51PM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 9126

Build Type

push

travis-ci

Committed by

benjyw

Commit Message

When a timeout triggers, first do SIGTERM, then wait a bit, and then do SIGKILL

The current implementation of timeouts sends a SIGKILL to the test, which doesn't let it write out XML files and whatnot. This change sends a SIGTERM, and gives it 10 seconds (by default. configurable with a new option) to die. If it doesn't die within 10 seconds, send a SIGKILL.

Testing Done:
```
% ./build-support/bin/unit-test.sh
<success>
% ./pants test.pytest --timeout-default=1 testprojects/tests/python/pants/timeout:ignores_terminate
09:27:47 00:01       [run]

09:27:47 00:01         [chroot]============== test session starts ===============
                     platform darwin -- Python 2.7.10 -- py-1.4.31 -- pytest-2.6.4
                     plugins: cov, timeout
                     collected 1 items

                     testprojects/tests/python/pants/timeout/test_ignores_terminate.py WARN] Timed out test did not terminate gracefully after 10 seconds, killing...

FAILURE: Timeout of 1 seconds reached

09:27:58 00:12   [complete]
               FAILURE
% ./pants test tests/python/pants_test/backend/python/tasks:pytest_run_integration
<success>
% ./pants test tests/python/pants_test/task:testrunner_task_mixin
<success>
```

Travis: https://travis-ci.org/pantsbuild/pants/builds/110994889

Bugs closed: 2949

Reviewed at https://rbcommons.com/s/twitter/r/3479/

Coverage Stats

Jobs

ID	Job ID	Ran
1	9126.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	22 Feb 2016 05:52PM UTC	Travis Job 9126.1
4	9126.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	22 Feb 2016 05:57PM UTC	Travis Job 9126.4
5	9126.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	22 Feb 2016 05:51PM UTC	Travis Job 9126.5
6	9126.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	22 Feb 2016 06:05PM UTC	Travis Job 9126.6
7	9126.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	22 Feb 2016 06:12PM UTC	Travis Job 9126.7
8	9126.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	22 Feb 2016 06:06PM UTC	Travis Job 9126.8
9	9126.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	22 Feb 2016 06:11PM UTC	Travis Job 9126.9

Source Files on build 9126

Detailed source file information is not available for this build.

pantsbuild / pants / 9126
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9126

pantsbuild / pants / 9126 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9126

pantsbuild / pants / 9126
0%
main: 93%

README BADGES
x