9106
0%
main: 93%

Ran 19 Feb 2016 12:26AM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 9106

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

[engine] Noop only a cyclic dependency, and not an entire Node

Rather than failing an entire Node when it attempts to introduce a cyclic dependency, we now fail only the cyclic dependency. To avoid _actually_ introducing cyclic dependencies into the graph, we store them independently, for use by consumers that understand them.

The effect of this change is that rather than immediately failing, the Node that requested the cyclic dependency might still be able to succeed via 1) some other source of the dependency, 2) the dependency being optional.

- Store cyclic dependencies independently, and provide them to Step rather than immediately failing the requesting Node
- Delete the `StructAddress` class, which existed only to work-around the current cycle handling
- Mark Noops white in the visualizer* (*in cases where they're actually rendered... for example, by passing `lambda _: True` as the walk predicate)

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/110253591

Bugs closed: 2938

Reviewed at https://rbcommons.com/s/twitter/r/3478/

Coverage Stats

Jobs

ID	Job ID	Ran
1	9106.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	19 Feb 2016 12:26AM UTC	Travis Job 9106.1
4	9106.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	19 Feb 2016 12:47AM UTC	Travis Job 9106.4
5	9106.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	19 Feb 2016 12:41AM UTC	Travis Job 9106.5
6	9106.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	19 Feb 2016 12:41AM UTC	Travis Job 9106.6
7	9106.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	19 Feb 2016 12:46AM UTC	Travis Job 9106.7
8	9106.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	19 Feb 2016 12:46AM UTC	Travis Job 9106.8
9	9106.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	19 Feb 2016 12:56AM UTC	Travis Job 9106.9

Source Files on build 9106

Detailed source file information is not available for this build.

pantsbuild / pants / 9106
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9106

pantsbuild / pants / 9106 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9106

pantsbuild / pants / 9106
0%
main: 93%

README BADGES
x