9068
0%
main: 93%

Ran 16 Feb 2016 05:22PM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 9068

Build Type

push

travis-ci

Committed by

peiyuwang

Commit Message

jar-tool properly skipping Manifest file using entry's jarPath

Since `entryPath=="MANIFEST.MF"`, the check for
`JarFile.MANIFEST_NAME.equals(entryPath)` will always be false, instead we
should check entry's jarPath, i.e, the path that's to be written into the jar.

This is surfaced by an uncommon new use case: some applications like scalding
need two main functions in their jars. The second main is supplied as a
MANIFEST.MF resource.

Now when running binary, `-files` contains `/path/to/META-INF/=META-INF/`,
manifest.mf is not skipped because of the above, and results
`duplicate entry: META-INF/MANIFEST.MF` error.

Note: for binary, skipping the 2nd manifest is the appropriate action. Because
there is only one manifest/main for the binary jar. For bundle, this code path
is not executed because we only generated synthetic classpath now.

Testing Done:
https://travis-ci.org/peiyuwang/pants/builds/107703027 passed

Bugs closed: 2899

Reviewed at https://rbcommons.com/s/twitter/r/3437/

Coverage Stats

Jobs

ID	Job ID	Ran
1	9068.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	16 Feb 2016 05:27PM UTC	Travis Job 9068.1
4	9068.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	16 Feb 2016 05:29PM UTC	Travis Job 9068.4
5	9068.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	16 Feb 2016 05:22PM UTC	Travis Job 9068.5
6	9068.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	16 Feb 2016 05:39PM UTC	Travis Job 9068.6
7	9068.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	16 Feb 2016 05:45PM UTC	Travis Job 9068.7
8	9068.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	16 Feb 2016 05:40PM UTC	Travis Job 9068.8
9	9068.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	16 Feb 2016 05:45PM UTC	Travis Job 9068.9

Source Files on build 9068

Detailed source file information is not available for this build.

pantsbuild / pants / 9068
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9068

pantsbuild / pants / 9068 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9068

pantsbuild / pants / 9068
0%
main: 93%

README BADGES
x