#869
93%

Ran 10 Jun 2022 09:52PM UTC

Jobs 1

Files 73

Run time 10s

Badge

Embed ▾

pending completion

Build # #869

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Fix false positive involving type parameter @Nullable annotations. (#609)

NullAway doesn't currently support `@Nullable` annotations on type
parameters. However, we had an error where a `@Nullable` annotation
in a type parameter of the return type of a method was being
interpreted as applying to the method return itself.

For example:

```
public static <R> Foo<@Nullable R> bar() { ... }

public static void baz() {
  bar().toString();
}
```

would mistakenly be considered a null dereference.

We introduce an additional check to `NullabilityUtil.getTypeUseAnnotations(...)`
which will retrieve the method return annotation for the following cases:

```
@Nullable public static <R> Foo<R> bar()
@Nullable public static <R> Foo<@Nullable R> bar()
public static <R> @Nullable Foo<R> bar()
```

Yet ignore the annotation inside the type parameter of `Foo`.

It is possible we might need to refactor this check when we actually start
handling nullability of type parameters.

Run Details

4771 of 5180 relevant lines covered (92.1%)

0.92 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	#869.1	10 Jun 2022 09:52PM UTC	0	92.1

Source Files on build #869

Detailed source file information is not available for this build.

uber / NullAway / #869
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #869

uber / NullAway / #869 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #869

uber / NullAway / #869
93%

README BADGES
x