#865
93%

Ran 31 May 2022 08:37PM UTC

Jobs 1

Files 73

Run time 20s

Badge

Embed ▾

pending completion

Build # #865

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Cleanups to AccessPath representation and implementation (#603)

This cleans up how we represent the root of an access path.  Previously we used a `Root` class which contained an `Element`, with a boolean field indicating if the root was actually the receiver (`this`, which has no `Element`).  Now, we just make the root a `@Nullable Element`, with `null` representing the receiver.  Since we check our code with NullAway now this should be safe 🙂 And it's a slightly more efficient representation.

Alongside that change, clean up some of the messy logic inside `AccessPath` for access path building.  In doing this cleanup, I noticed that our streams handling didn't correctly handle cases involving a stream of `Map`s.  Not super realistic, but in any case it is fixed now and a test is added.

Run Details

4770 of 5179 relevant lines covered (92.1%)

0.92 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	88.75	-0.14%	../nullaway/src/main/java/com/uber/nullaway/dataflow/NullnessStore.java
4	91.18	-0.25%	../nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPathNullnessAnalysis.java
6	95.74	1.37%	../nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPath.java
14	83.53	-0.19%	../nullaway/src/main/java/com/uber/nullaway/handlers/OptionalEmptinessHandler.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#865.1	31 May 2022 08:37PM UTC	73	92.1

uber / NullAway / #865
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #865

uber / NullAway / #865 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #865

uber / NullAway / #865
93%

README BADGES
x