pantsbuild / pants / 8953
0%
main: 93%

LAST BUILD BRANCH: use_pants_lock_in_uv
DEFAULT BRANCH: main
Ran
Jobs 7
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8953

push

travis-ci

peiyuwang 
bug fix: remove duplicate 3rdparty jars in the bundle

https://rbcommons.com/s/twitter/r/3329/ introduced `classpath_util.classpath_by_targets`

Among classpath grouped by target (3rdparty dependencies) duplicates are not
removed. So we see for example same guava library have more than one symlink
created. This results typically 10%-20% increase in size.

An example:
```
tw-mbp-peiyu:source peiyu$ ls -l dist/buildstats-package-dist-bundle/libs/|grep 3rdparty|grep guava
lrwxrwx---  1 peiyu  staff   95 Jan 20 13:53 3rdparty.jvm.cascading.cascading-local-4.jar -> /Users/peiyu/workspace/source/.pants.d/ivy/jars/com.google.guava/guava/bundles/guava-16.0.1.jar
lrwxrwx---  1 peiyu  staff   95 Jan 20 13:53 3rdparty.jvm.com.github.spullara.mustache.java.java-1.jar -> /Users/peiyu/workspace/source/.pants.d/ivy/jars/com.google.guava/guava/bundles/guava-16.0.1.jar
lrwxrwx---  1 peiyu  staff   95 Jan 20 13:53 3rdparty.jvm.com.google.guava.guava-0.jar -> /Users/peiyu/workspace/source/.pants.d/ivy/jars/com.google.guava/guava/bundles/guava-16.0.1.jar
lrwxrwx---  1 peiyu  staff   95 Jan 20 13:53 3rdparty.jvm.com.google.inject.extensions.guice-assistedinject-3.jar -> /Users/peiyu/workspace/source/.pants.d/ivy/jars/com.google.guava/guava/bundles/guava-16.0.1.jar
lrwxrwx---  1 peiyu  staff   95 Jan 20 13:53 3rdparty.jvm.com.google.inject.extensions.guice-multibindings-3.jar -> /Users/peiyu/workspace/source/.pants.d/ivy/jars/com.google.guava/guava/bundles/guava-16.0.1.jar
lrwxrwx---  1 peiyu  staff   95 Jan 20 13:53 3rdparty.jvm.com.google.inject.guice-2.jar -> /Users/peiyu/workspace/source/.pants.d/ivy/jars/com.google.guava/guava/bundles/guava-16.0.1.jar
lrwxrwx---  1 peiyu  staff   95 Jan 20 13:53 3rdparty.jvm.net.codingwell.scala-guice-2.jar -> /Users/peiyu/workspace/source/.pants.d/ivy/jars/com.google.guava/guava/bundles/guava-16.0.1.jar
```

This review removes duplicated jars.

Note: `classpath.txt` should still contain all the dependencies for the target.
No need to 'dedup' because they are used by intellij.

Note: this review is limited to bug fix. Next time when we remove the
`use_target_id` flag, will probably do more cleanups since the logic is getting
complicated.

Testing Done:
https://travis-ci.org/peiyuwang/pants/builds/106558822 passed

Bugs closed: 2876

Reviewed at https://rbcommons.com/s/twitter/r/3412/
Jobs
ID Job ID Ran Files Coverage
1 8953.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 8953.1
4 8953.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 8953.4
5 8953.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 8953.5
7 8953.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 8953.7
8 8953.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 8953.8
9 8953.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 8953.9
10 8953.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 8953.10
Source Files on build 8953
Detailed source file information is not available for this build.