8948
0%
main: 93%

Ran 05 Feb 2016 10:13PM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 8948

Build Type

push

travis-ci

Committed by

gmalmquist

Commit Message

Retain file permissions when shading monolithic jars.

On some systems (macos at least), the atomic_copy function at the
end of the jar shading process would cause the file permissions to
be set to '-rw-------', instead of the normal '-rw-r--r--', because
of the permissions of the temporary file that atomic_copy creates.

This change simply records the permissions of the jar before
shading, and chmod's the shaded jar to have whatever permissions it
had previously.

Testing Done:
Added an integration test to `test_shader_integration.py`.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/107310100

Bugs closed: 2885

Reviewed at https://rbcommons.com/s/twitter/r/3420/

Coverage Stats

Jobs

ID	Job ID	Ran
1	8948.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	05 Feb 2016 10:13PM UTC	Travis Job 8948.1
4	8948.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	05 Feb 2016 10:30PM UTC	Travis Job 8948.4
5	8948.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	05 Feb 2016 10:17PM UTC	Travis Job 8948.5
7	8948.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	05 Feb 2016 10:29PM UTC	Travis Job 8948.7
8	8948.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	05 Feb 2016 10:27PM UTC	Travis Job 8948.8
9	8948.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	05 Feb 2016 10:26PM UTC	Travis Job 8948.9
10	8948.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	05 Feb 2016 10:34PM UTC	Travis Job 8948.10

Source Files on build 8948

Detailed source file information is not available for this build.

pantsbuild / pants / 8948
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8948

pantsbuild / pants / 8948 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8948

pantsbuild / pants / 8948
0%
main: 93%

README BADGES
x