8815
0%
main: 93%

Ran 28 Jan 2016 09:44PM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 8815

Build Type

push

travis-ci

Committed by

gmalmquist

Commit Message

Don't skip writing <artifact>s to ivy.xml even if there's only one.

We ran into a problem internally at Square where ivy would
stubbornly resolve a 'test-jar' instead of a 'jar' artifact, even
when we directly declared a dependency on the 'jar'. The reason for
this appears to be that pants was short-circuiting instead of
writing an explicit artifact for the 'jar'.

This changes:

```
   <dependency org="org.apache.hadoop"
                  name="hadoop-common"
                  rev="2.0.0-cdh4.6.0">
        <conf name="default" mapped="default"/>
        <!-- excludes, etc -->
    </dependency>
```

To:

```
   <dependency org="org.apache.hadoop"
                  name="hadoop-common"
                  rev="2.0.0-cdh4.6.0">
        <conf name="default" mapped="default"/>
        <artifact
          name="hadoop-common"
          type="jar"/>
        <!-- excludes, etc -->
    </dependency>
```

Which causes ivy to behave as expected.

Testing Done:
This fixed our internal problem, and didn't break anything.

Manually confirmed that features like `export --libraries-sources` which have been historically fragile and prone to regression still work.

CI passed here: https://travis-ci.org/pantsbuild/pants/builds/105511558

Bugs closed: 2853

Reviewed at https://rbcommons.com/s/twitter/r/3388/

Coverage Stats

Jobs

ID	Job ID	Ran
1	8815.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	28 Jan 2016 09:44PM UTC	Travis Job 8815.1
4	8815.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	28 Jan 2016 10:05PM UTC	Travis Job 8815.4
5	8815.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	28 Jan 2016 09:53PM UTC	Travis Job 8815.5
6	8815.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	28 Jan 2016 09:54PM UTC	Travis Job 8815.6
7	8815.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	28 Jan 2016 09:57PM UTC	Travis Job 8815.7
8	8815.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	28 Jan 2016 09:56PM UTC	Travis Job 8815.8
10	8815.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	28 Jan 2016 10:03PM UTC	Travis Job 8815.10

Source Files on build 8815

Detailed source file information is not available for this build.

pantsbuild / pants / 8815
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8815

pantsbuild / pants / 8815 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8815

pantsbuild / pants / 8815
0%
main: 93%

README BADGES
x