8670
0%
main: 93%

Ran 20 Jan 2016 05:46PM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 8670

Build Type

push

travis-ci

Committed by

baroquebobcat

Commit Message

Make more glob usages lazy; Pass FilesetWithSpec through source field validation, Make BundleProps.filemap lazy

One of the things that consumes a lot of time while parsing BUILD build files is loading the values of globs eagerly. Two of the places this happens are during sources field validation and generating the filemap for jvm app bundles.

This changes SourcesField so it allows FilesetWithSpec, ie globs, to be passed through without being converted into a list. This allows globs to remain unfulfilled until use rather than eagerly doing directory scanning on target initialization.

It also changes jvm_app's bundle so that its filemap is also lazily created rather than eagerly.

Testing Done:
Added a test case for passthrough, ran ci.

Travis passed https://travis-ci.org/pantsbuild/pants/builds/103508419

Bugs closed: 2794

Reviewed at https://rbcommons.com/s/twitter/r/3344/

Coverage Stats

Jobs

ID	Job ID	Ran
1	8670.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	20 Jan 2016 09:51PM UTC	Travis Job 8670.1
4	8670.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	20 Jan 2016 08:01PM UTC	Travis Job 8670.4
5	8670.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	20 Jan 2016 07:57PM UTC	Travis Job 8670.5
6	8670.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	20 Jan 2016 08:02PM UTC	Travis Job 8670.6
7	8670.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	20 Jan 2016 07:56PM UTC	Travis Job 8670.7
8	8670.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	20 Jan 2016 07:58PM UTC	Travis Job 8670.8
10	8670.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	20 Jan 2016 08:06PM UTC	Travis Job 8670.10

Source Files on build 8670

Detailed source file information is not available for this build.

pantsbuild / pants / 8670
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8670

pantsbuild / pants / 8670 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8670

pantsbuild / pants / 8670
0%
main: 93%

README BADGES
x