39312
39%

Ran 10 Mar 2022 08:07PM UTC

Jobs 2

Files 910

Run time 43min

Badge

Embed ▾

Committed 10 Mar 2022 07:20PM UTC coverage: 35.06% (+0.03%) from 35.029%

Build # 39312

Build Type

push

travis-ci-com

Committed by

joestringer

Commit Message

Makefile: Fix TESTPKGS commandline

Commit 51647bbdbd22 ("Makefile: Simplify to run faster") mistakenly
added a '/' to the end of the '$(ROOT_DIR)' in the substitution, which
invalidated the greps that attempted to exclude directories that do not
need to trigger unit tests, for instance the `test/` directory. As a
result, when running commands like `make integration-tests`, it was easy
to inadvertently attempt to run the end-to-end tests in an environment
that cannot run the end-to-end-tests.

Fix this issue by injecting a leading '/' before each package, so that
the package grep can match on that leading '/' in order to properly
select directories based on their path from the root directory. The
extra sed command will then filter the leading '/' back out before
passing that variable on.

While we're at it, fold the '/test' match into the main grep expression
and avoid updating the TESTPKGS_EVAL during initial Makefile evaluation,
to further speed up the calculation.

Fixes: 51647bbdbd22 ("Makefile: Simplify to run faster")
Signed-off-by: Joe Stringer <joe@cilium.io>

Coverage Stats

44806 of 127797 relevant lines covered (35.06%)

4983.72 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	39312.1	10 Mar 2022 08:07PM UTC	0	35.06	Travis Job 39312.1
3	39312.3 (RACE=1 BASE_IMAGE=quay.io/cilium/cilium-runtime:514cbfc3fccb32fb67193b4b686f508b2fa26621@sha256:30cf45c1feadd04d367c446d0a3e3530d85be1b1e86f166f2862fdc09950f6a0 LOCKDEBUG=1)	10 Mar 2022 08:45PM UTC	0	35.05	Travis Job 39312.3

Source Files on build 39312

Detailed source file information is not available for this build.

cilium / cilium / 39312
39%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 39312

cilium / cilium / 39312 39%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 39312

cilium / cilium / 39312
39%

README BADGES
x