pantsbuild / pants / 8596
0%
main: 93%

LAST BUILD BRANCH: tdyas/pytest-9
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8596

push

travis-ci

jsirois 
Support `go test` blackbox tests.

The `go test` command supports black box tests.  These are tests that
live in the package directory of code they test, but which declare a
different package, namely a package of the same name as the test file.
For example, `lib/lib.go` might be tested by `lib/lib_test.go` which
declares itself to be in the `lib_test` package.  Since
`lib/lib_test.go` is in a different package from `lib/lib.go` it can
only access its exported symbols, and so black box testing is enforced
by the compiler.

The `go list` command, used by pants to form go roots and generate go
BUILD files categorizes imports from this style of test differently from
"normal" tests; ie: instead of listing these test imports under the
`TestImports` key, they are listed under the `XTestImports` key.  Add
support for this 3rd import category and arrange for `GoBuildgen` to
support these imports while simultaneously removing support for test
imports of either kind from `GoFetch`.  The latter is done for
simplicity since a remote libs test imports would only ever be needed to
run that remote lib's tests locally.

A failing test was added for a target with a black box test that is
fixed by this change.

Testing Done:
Failing test added which now runs green.

CIs went green here:
  https://travis-ci.org/pantsbuild/pants/builds/101649933
  http://ec2-54-146-169-50.compute-1.amazonaws.com:8080/job/pants_ci_trigger/67/

Bugs closed: 2787, 2791

Reviewed at https://rbcommons.com/s/twitter/r/3327/
Jobs
ID Job ID Ran Files Coverage
1 8596.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 8596.1
4 8596.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 8596.4
5 8596.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 8596.5
6 8596.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 8596.6
7 8596.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 8596.7
8 8596.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 8596.8
9 8596.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 8596.9
10 8596.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 8596.10
Source Files on build 8596
Detailed source file information is not available for this build.