pantsbuild / pants / 8542
0%
main: 93%

LAST BUILD BRANCH: free-threaded-python
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8542

push

travis-ci

stuhood 
Move Sources to a target's configurations, and add subclasses for each language

Since resources don't have any particular extension, they need to be explicitly marked as being resources. In addition, since it is possible that a user might want to explicitly treat a non-compilable `.java` file (as an example) as a resource, it's important that the JavacPlanner not use (only) the extension to determine the type of a source.

This change uses subclasses of `Sources` to differentiate between sources of different types/extensions, and moves Sources off of their distinguished place on `Target`, and into the configurations list.

- Make Sources abstract, with an `extensions` property, which could become a default filter on globs for instances of a `Sources` subclass, but it is currently only used for validation of literal `files` lists
- Move Sources to the configurations list for a target, which allows for uniform selection of configuration by type
- Add a helper to `Target` to match configuration by type
- Add ResourcesPlanner to provide a Classpath for Resources
- Add an example java project that consumes resources

----

One downside of this change is that every useful Target will have at least one `configurations` member: I think we're going to want to lower the friction on defining configurations as close to zero as possible, perhaps by having them defined as a repeated parameter on the end of the Target constructor, rather than in a nested list?

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/100917174

Bugs closed: 2634, 2744

Reviewed at https://rbcommons.com/s/twitter/r/3274/
Jobs
ID Job ID Ran Files Coverage
1 8542.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 8542.1
4 8542.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 8542.4
5 8542.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 8542.5
6 8542.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 8542.6
7 8542.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 8542.7
8 8542.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 8542.8
9 8542.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 8542.9
10 8542.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 8542.10
Source Files on build 8542
Detailed source file information is not available for this build.