pantsbuild / pants / 8532
0%
main: 93%

LAST BUILD BRANCH: dk-uv-selective-sync
DEFAULT BRANCH: main
Ran
Jobs 7
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8532

push

travis-ci

ericzundel 
Update pinger timeout in test_pinger_timeout_config and test_global_pinger_memo.

Remove get_delayed_handler() as it had been moved to delay_server.py previously.

Add assertion message.

Peiyu's results showed the CI can slow timeout by at least .02, as shown here, where timeout was set to .04, but failed to time out and returned a time of .058:
```
E     AssertionError: 0.05868887901306152 != 999999
```

I set up the variables such that they have equal spacing with each other and experimented with different values. with a resolution of .01 the test ran in 3 seconds:
```
============== test session starts ===============
                     platform linux2 -- Python 2.7.6 -- py-1.4.30 -- pytest-2.6.4
                     plugins: cov, timeout
                     collected 3 items

                     tests/python/pants_test/cache/test_pinger.py ...

                     ============ 3 passed in 3.08 seconds ============

```
Changing the resolution to .1 resulted in a test that ran only 1 second slower:
```
 ============== test session starts ===============
                     platform linux2 -- Python 2.7.6 -- py-1.4.30 -- pytest-2.6.4
                     plugins: cov, timeout
                     collected 3 items

                     tests/python/pants_test/cache/test_pinger.py ...

                     ============ 3 passed in 4.05 seconds ============

```

I think a resolution of .1 should be sufficient that a slow machine won't fail the test. If not, it's now really easy to adjust.

Testing Done:
CI is running: https://travis-ci.org/pantsbuild/pants/builds/100273465

Bugs closed: 2765

Reviewed at https://rbcommons.com/s/twitter/r/3292/
Jobs
ID Job ID Ran Files Coverage
1 8532.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 8532.1
5 8532.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 8532.5
6 8532.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 8532.6
7 8532.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 8532.7
8 8532.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 8532.8
9 8532.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 8532.9
10 8532.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 8532.10
Source Files on build 8532
Detailed source file information is not available for this build.