pantsbuild / pants / 8483
0%
main: 93%

LAST BUILD BRANCH: nodejs-tool-bundled-lockfiles
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8483

push

travis-ci

Peiyu Wang 
Flatten stable classpath for bundle

This is to continue the recent work on bundle, for making the bundle fat jar
slimmer by switching to use stable classpath.

Turns out many tools, hadoop in particular, assume a flatten directory
structure for jars under libs/, and jar names are used for caching purpose and
need to be unique. This review is to solve this problem by switching to a flat
structure, external jars under libs/, internal jars under internal-libs/.

Since maven namings (a-b-1.2.3.jar) and pants target.id based naming (a.b-0.jar)
are in different styles: pants' always have a dot before the dash. Very unlikely
there is name conflict between them.

Now app-bundle/ directory will include
```
app-bundle.jar // this only sets Class-Path + other Manifest entries
libs/
libs/x-1.2.3.jar
libs/others-4.5.6.jar
internal-libs/a.b.c-0.jar
internal-libs/a.b.c-1 // this could be a resource directory, there will be another review to make this a jar (only for performance benefit)
internal-libs/a.b.c-classpath.txt
...
```
This change includes:
- Place internal jars under internal-libs/ and 3rdparty jars under libs/
- Append an unique index for multiple classpath entries belong to the same target
- Continue to handle legacy naming used only by intellij plugin vs target.id
  based naming, code will be simplified once we deprecate the former

Testing Done:
https://travis-ci.org/peiyuwang/pants/builds/97395450

Bugs closed: 2729

Reviewed at https://rbcommons.com/s/twitter/r/3261/
Jobs
ID Job ID Ran Files Coverage
1 8483.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 8483.1
4 8483.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 8483.4
5 8483.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 8483.5
6 8483.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 8483.6
7 8483.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 8483.7
8 8483.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 8483.8
9 8483.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 8483.9
10 8483.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 8483.10
Source Files on build 8483
Detailed source file information is not available for this build.