pantsbuild / pants / 8443
0%
main: 91%

LAST BUILD BRANCH: infer-python-dist-ics-from-pyproject
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8443

push

travis-ci

stuhood 
Have SourcesField handle the calculation of SourceRoots

We're killing some old code internally that extends IvyTaskMixin, and having it use UnpackedJars instead. During the course of that, I noticed that source_roots were not getting registered correctly for all generated code; particularly deferred sources.

There were twoish issues: `simple_codegen_task` was adding absolute sourceroots, which would not match anything later, and in order for deferred sources to have a valid source root, it needed the source root to be rooted where its sources lived (under `.pants.d`), rather than at its own target address.

- Move SourcesField to the source package in order to allow it to more easily have a dep on the SourceRoots object
- Remove `FilesetWithSpec` dependency from `assert_list` and remove `validation`'s dependency on the `source` package
- Use the null-object pattern with SourcesField
- Add `def source_root` to SourcesField, and use the rel_path of the sources to do source_root lookups, rather than the target address
- Fix issue in `source_root.py` where `add_source_root` was adding absolute paths rather than relative paths, which caused the addition of source roots in `simple_codegen_task` to be a noop

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/99189335

also manually validated that this allows us to use deferred_sources/unpacked_jars with scrooge

Bugs closed: 2688

Reviewed at https://rbcommons.com/s/twitter/r/3230/
Jobs
ID Job ID Ran Files Coverage
1 8443.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 8443.1
4 8443.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 8443.4
5 8443.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 8443.5
6 8443.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 8443.6
7 8443.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 8443.7
8 8443.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 8443.8
9 8443.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 8443.9
10 8443.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 8443.10
Source Files on build 8443
Detailed source file information is not available for this build.