8415
0%
main: 93%

Ran 20 Dec 2015 09:55PM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 8415

Build Type

push

travis-ci

Committed by

patricklaw

Commit Message

Explicitly track when synthetic targets are injected.

Previously some degree of tracking was done in `Context` to ensure
that synthetic targets were pulled into `context.targets()` if their
concrete ancestors were in the root targets of the graph.  However,
recent work by Matt Olsen in https://rbcommons.com/s/twitter/r/3225/
revealed a more subtle issue with `BuildGraph`'s handling of
synthetic targets: some synthetic targets do not have meaningful
ancestors, and we currently don't model that case.

This change makes it so that being "derived from" some other target
is sufficient but no longer necessary to be considered "synthetic".
Callers of `BuildGraph.inject_target` can now pass `synthetic=True`
to force this attribute of a target, even if it does not derive
from another target.  In particular, `BuildGraph.inject_synthetic_target`
passes `synthetic=True`.

Testing Done:
CI is green:
https://travis-ci.org/pantsbuild/pants/builds/97998009

Bugs closed: 2749

Reviewed at https://rbcommons.com/s/twitter/r/3277/

Coverage Stats

Jobs

ID	Job ID	Ran
1	8415.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	20 Dec 2015 09:55PM UTC	Travis Job 8415.1
4	8415.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	20 Dec 2015 10:08PM UTC	Travis Job 8415.4
5	8415.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	20 Dec 2015 09:59PM UTC	Travis Job 8415.5
6	8415.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	20 Dec 2015 10:03PM UTC	Travis Job 8415.6
7	8415.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	20 Dec 2015 10:01PM UTC	Travis Job 8415.7
8	8415.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	20 Dec 2015 10:03PM UTC	Travis Job 8415.8
9	8415.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	20 Dec 2015 10:08PM UTC	Travis Job 8415.9
10	8415.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	20 Dec 2015 10:13PM UTC	Travis Job 8415.10

Source Files on build 8415

Detailed source file information is not available for this build.

pantsbuild / pants / 8415
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8415

pantsbuild / pants / 8415 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8415

pantsbuild / pants / 8415
0%
main: 93%

README BADGES
x