8386
0%
main: 93%

Ran 18 Dec 2015 12:36AM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 8386

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Make jvm_compile's subsystem dependencies global to fix ignored options

This change addresses the issue that the `--scala-platform-compile-zinc-fatal-warnings` and `--java-compile-zinc-fatal-warnings` options are registered/recognized, but never used. Rather than actually using a task-specific instance of the subsystem, jvm_compile uses the global instance, and probably should.

- Made JvmCompile's subsystem dependencies global, and moved from the deprecated `task_subsystem`/`global_subsystem` API to the scoping API
- Added a negative test to confirm that passing the option in the incorrect position explodes
- Fixed a bug in `subsystem_dependencies_iter` where the scope of global options was incorrect, which caused them not to be fingerprinted
- Added a TODO to track [#2739](https://github.com/pantsbuild/pants/issues/2739), which was discovered here

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/97571757

Bugs closed: 2696

Reviewed at https://rbcommons.com/s/twitter/r/3238/

Coverage Stats

Jobs

ID	Job ID	Ran
1	8386.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	18 Dec 2015 12:40AM UTC	Travis Job 8386.1
4	8386.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	18 Dec 2015 12:46AM UTC	Travis Job 8386.4
5	8386.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	18 Dec 2015 12:36AM UTC	Travis Job 8386.5
6	8386.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	18 Dec 2015 12:42AM UTC	Travis Job 8386.6
7	8386.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	18 Dec 2015 12:45AM UTC	Travis Job 8386.7
8	8386.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	18 Dec 2015 12:51AM UTC	Travis Job 8386.8
9	8386.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	18 Dec 2015 12:49AM UTC	Travis Job 8386.9
10	8386.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	18 Dec 2015 12:56AM UTC	Travis Job 8386.10

Source Files on build 8386

Detailed source file information is not available for this build.

pantsbuild / pants / 8386
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8386

pantsbuild / pants / 8386 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8386

pantsbuild / pants / 8386
0%
main: 93%

README BADGES
x