8285
0%
main: 93%

Ran 12 Dec 2015 01:34AM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 8285

Build Type

push

travis-ci

Committed by

patricklaw

Commit Message

Prepend '//' to Address.spec when the spec_path is empty.

Also fix a bug in Address.reference that this revealed: namely
that spec_path-relative references at the root were actually
going through the code path for absolute references, but
because the result was identical it didn't matter.

An issue in https://rbcommons.com/s/twitter/r/3225/ uncovered a bug in the way we
handle addresses at the root of the repo (i.e. with an empty spec_path) in the
context of Target.traversable_dependency_specs.  These specs are always with respect
to the target being loaded, meaning that relative spec paths are relative to
the target's spec_path.  This means that specs with an empty spec_path must
be disambiguated by prepending //, otherwise they will be treated as a relative
spec.

Testing Done:
Had to fix up lots of little assertions that rely on the spec formatting.

CI is green: https://travis-ci.org/pantsbuild/pants/builds/96364177

Bugs closed: 2693

Reviewed at https://rbcommons.com/s/twitter/r/3234/

Coverage Stats

Jobs

ID	Job ID	Ran
1	8285.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	12 Dec 2015 01:36AM UTC	Travis Job 8285.1
4	8285.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	12 Dec 2015 01:44AM UTC	Travis Job 8285.4
5	8285.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	12 Dec 2015 01:34AM UTC	Travis Job 8285.5
6	8285.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	12 Dec 2015 01:41AM UTC	Travis Job 8285.6
7	8285.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	12 Dec 2015 01:46AM UTC	Travis Job 8285.7
8	8285.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	12 Dec 2015 01:46AM UTC	Travis Job 8285.8
9	8285.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	12 Dec 2015 01:50AM UTC	Travis Job 8285.9
10	8285.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	12 Dec 2015 01:49AM UTC	Travis Job 8285.10

Source Files on build 8285

Detailed source file information is not available for this build.

pantsbuild / pants / 8285
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8285

pantsbuild / pants / 8285 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8285

pantsbuild / pants / 8285
0%
main: 93%

README BADGES
x