pantsbuild / pants / 8236
0%
main: 93%

LAST BUILD BRANCH: fix_uv_remcache
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8236

push

travis-ci

stuhood 
Create a test timeout_maximum flag so that we can prevent people from setting an insanely huge timeout

Creates a new timeout-maximum flag, if someone sets a timeout that exceeds that flag, then the timeout will be capped at that flag's level.

Also, start to deprecate timeout=0. Usage here has been very confusing, people thought that timeout=0 disabled the timeout, when really the behavior we have where the timeout can't be disabled is correct, if timeout=None then the default timeout should be used. timeout=0 should either really mean timeout=0 which fails the tests, or it should be prevented altogether. This RB just adds a warning if people use timeout=0.

Testing Done:
./pants test tests/python/pants_test/task:testrunner_task_mixin
./pants test tests/python/pants_test/base:deprecated

Set timeout=0 in tests/python/pants_test/task:testrunner_task_mixin

./pants test tests/python/pants_test/task:testrunner_task_mixin

saw the warning:

```
09:23:49 00:01     [pytest]WARN] /Users/sbrenn/workspace/pants/src/python/pants/task/testrunner_task_mixin.py:113: DeprecationWarning:
"Timeout for tests/python/pants_test/task:testrunner_task_mixin is 0" is deprecated and will be removed in version 0.0.65:
To use the default timeout remove the 'timeout' parameter from your test target.
  timeouts = [self._timeout_for_target(target) for target in targets]
```

Set timeout=10, saw the warning:
./pants test --test-pytest-timeout-maximum=5 tests/python/pants_test/task:testrunner_task_mixin

```
                   Warning: Timeout for tests/python/pants_test/task:testrunner_task_mixin (10s) exceeds 5s. Capping.
```

./pants test --test-pytest-timeout-default=20 --test-pytest-timeout-maximum=5 tests/python/pants_test/task:testrunner_task_mixin
                   Error: timeout-default: 5 exceeds timeout-maximum: 20
FAILURE: Error: timeout-default: 5 exceeds timeout-maximum: 20

Travis CI: https://travis-ci.org/pantsbuild/pants/builds/95896930

Reviewed at https://rbcommons.com/s/twitter/r/3219/
Jobs
ID Job ID Ran Files Coverage
1 8236.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 8236.1
4 8236.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 8236.4
5 8236.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 8236.5
6 8236.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 8236.6
7 8236.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 8236.7
8 8236.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 8236.8
9 8236.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 8236.9
10 8236.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 8236.10
Source Files on build 8236
Detailed source file information is not available for this build.