8224
0%
main: 93%

Ran 09 Dec 2015 01:46AM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 8224

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Use target.id to create the stable classpath for bundle and export-classpath

Today, for target a/b:b we create a symlink under a/b/b, current implementation
first delete everything under a/b/b, this is probalematic.

Consider target a/b:b and a/b/b/c:c whose stable classpath share the same
prefix: `a/b/b`

1. a/b/b/c:c first creates a stable symlink a/b/b/c/c/0-z.jar
2. a/b:b calls safe_rmtree('a/b/b') previous symlink will be deleted

The original intent to do `rmtree` my guess is to clear symlinks that already
exist during incremental build, but didn't consider targets may share share
common prefix.

This review
1. delete only non-directories under the current directory, not the entire tree
2. Provide an option to use `target.id` as the safe unique identifier.
   Switch to use `target.id` for `bundle`, but continue to use the old naming
   for `export-classpath` since it requires coordination of Intellij plugin.

Testing Done:
Locally tested on a previously failing bundle

https://travis-ci.org/peiyuwang/pants/builds/95140740 passed

Bugs closed: 2664

Reviewed at https://rbcommons.com/s/twitter/r/3211/

Coverage Stats

Jobs

ID	Job ID	Ran
1	8224.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	09 Dec 2015 01:46AM UTC	Travis Job 8224.1
4	8224.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	09 Dec 2015 02:00AM UTC	Travis Job 8224.4
5	8224.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	09 Dec 2015 01:55AM UTC	Travis Job 8224.5
6	8224.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	09 Dec 2015 01:54AM UTC	Travis Job 8224.6
7	8224.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	09 Dec 2015 01:56AM UTC	Travis Job 8224.7
8	8224.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	09 Dec 2015 02:00AM UTC	Travis Job 8224.8
9	8224.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	09 Dec 2015 02:05AM UTC	Travis Job 8224.9
10	8224.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	09 Dec 2015 02:08AM UTC	Travis Job 8224.10

Source Files on build 8224

Detailed source file information is not available for this build.

pantsbuild / pants / 8224
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8224

pantsbuild / pants / 8224 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8224

pantsbuild / pants / 8224
0%
main: 93%

README BADGES
x