8191
0%
main: 93%

Ran 04 Dec 2015 10:20PM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 8191

Build Type

push

travis-ci

Committed by Benjy

Commit Message

Deprecate calling with_description() when registering a task.

The problem is that this description was associated with the
*goal* the task was registered on, not the task itself.

This meant that we were dependent on registration order. More
problematically, it meant that, e.g., the JVM backend was
creating descriptions for generic goals such as compile and test.

Instead, we introduce an explicit Goal.register(name, description)
solely for providing descriptions for generic, multiple-task goals.

Then we enumerate the generic goals in core_tasks/register.py.

Single-task goals take their description from the task's docstring,
so this change also ensures that we have appropriate docstrings
everywhere.

Testing Done:
CI passes: https://travis-ci.org/pantsbuild/pants/builds/94713238

Reviewed at https://rbcommons.com/s/twitter/r/3207/

Coverage Stats

Jobs

ID	Job ID	Ran
1	8191.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	04 Dec 2015 10:20PM UTC	Travis Job 8191.1
4	8191.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	04 Dec 2015 10:28PM UTC	Travis Job 8191.4
5	8191.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	04 Dec 2015 10:31PM UTC	Travis Job 8191.5
6	8191.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	04 Dec 2015 10:28PM UTC	Travis Job 8191.6
7	8191.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	04 Dec 2015 10:30PM UTC	Travis Job 8191.7
8	8191.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	04 Dec 2015 10:30PM UTC	Travis Job 8191.8
9	8191.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	04 Dec 2015 10:34PM UTC	Travis Job 8191.9
10	8191.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	04 Dec 2015 10:40PM UTC	Travis Job 8191.10

Source Files on build 8191

Detailed source file information is not available for this build.

pantsbuild / pants / 8191
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8191

pantsbuild / pants / 8191 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8191

pantsbuild / pants / 8191
0%
main: 93%

README BADGES
x