AdamStelmaszczyk / gtsa / 477

88%

Build Type

push

travis-ci-com

Committed by Adam Stelmaszczyk

Commit Message

Fix the UCT maximization

This fixes a severe bug that was making MCTS + UCT much weaker.
Root player moves was corractly taken as:

max(ratio + UCT)

However, for the opponent wrong moves were taken:

min(ratio - UCT)

I thought it was doing:

min(- ratio - UCT)

which would be correct.

Right now I also simplified by always taking max - ratio (score)
is always stored with the respect to the player_to_move.

So e.g. root player has score = 0.7. However on opponent turn
we also want to take max, so want to have score 0.3 (for the same state).
To do this I pass "player" argument to the get_uct function,
to get UCT with respect to that player.

It passes all the units test, it also wins with Minimax(0.1)
when given 10s (does ~70-90k simulations). When given 1s (~7k simulations)
it loses. In 0.1s Minimax looks at ~80k positions, so MCTS is much slower.
There is probably a lot of optimization space in MCTS, e.g. unordered_set.
Also not sure that get_most_visited_move is the best choice, will test that later.

Run Details

18 of 18 new or added lines in 1 file covered. (100.0%)

761 of 851 relevant lines covered (89.42%)

266300.09 hits per line