pantsbuild / pants / 8109
0%
main: 93%

LAST BUILD BRANCH: upgrade_pex
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
8109

push

travis-ci

ericzundel 
Refactor detect_duplicates with some user friendly features

I was having a hard time making the duplicate output make sense in the Square repo.  First of all, developers don't want to see this output, so I wanted a way for them to just turn it off until I can get the dups out of properly excluded.  Also, we have known conflicts in our resources that I wanted to exclude which the exising logic was unable to suppress.  Many of the files that were coming up were nusciance, I wanted more flexibility on how to exclude them.

    - Deprecate the 'excludes' argument.  The only thing that won't be accepted by the new arguments is that `--excludes` accepts a list of comma separated values.
    - Added --exclude-files to replace --excludes
    - Added --exclude-dirs to exclude directories
    - Added --exclude-patterns to use a regular expression
    - Added --skip to easily turn off the duplicate checking feature
    - Moved logic out of __init__()
    - Moved the logic to check for excludes to a central place where it can
        be used to exclude classes on the classpath, not just artifacts in jars
    - Default to excluding the security files META-INF/*.RSA META-INF/*.DSA META-INF/*.SF.  The security file prefixes are automatically excluded by jvm_binary as well. Added a regular expression feature to cull them out.
    - Default to excluding META-INF/services files.  Any file that begins with META-INF/services is expected to have conflicts - the logic in jvm_binary merges them together.

migrations/options/src/python/migrate_config.py         |  1 +
src/python/pants/backend/jvm/tasks/BUILD                |  2 ++
src/python/pants/backend/jvm/tasks/detect_duplicates.py | 80 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------
tests/python/pants_test/tasks/test_detect_duplicates.py | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----
4 files changed, 137 insertions(+), 22 deletions(-)

Testing Done:
CI is green at https://travis-ci.org/pantsbuild/pants/builds/93253628
Updated the unit tests
Tested this in our repo and confirmed the internal resources can now be excluded.

Bugs closed: 2625

Reviewed at https://rbcommons.com/s/twitter/r/3178/
Jobs
ID Job ID Ran Files Coverage
1 8109.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 8109.1
4 8109.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 8109.4
5 8109.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 8109.5
6 8109.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 8109.6
7 8109.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 8109.7
8 8109.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 8109.8
9 8109.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 8109.9
10 8109.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 8109.10
Source Files on build 8109
Detailed source file information is not available for this build.