8016
0%
main: 93%

Ran 21 Nov 2015 10:23PM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 8016

Build Type

push

travis-ci

Committed by

patricklaw

Commit Message

Add a helper staticmethod `closure()` to `BuildGraph`.

Testing Done:
`BuildGraph.closure()` emulates `Target.closure()` but instead accepts a (potentially empty) iterable of
targets and computes their closure all at once using the efficient implementations in `BuildGraph`.

`BuildGraph.closure()` will delegate to the appropriate bfs vs dfs implementation on `BuildGraph` based on
the passed `bfs` parameter (defaults to `False`).  It will not pass through predicates or `postorder` when
in `dfs` mode.

Because of the peeking at `Target._build_graph`, which is private, this isn't an ideal long-term solution--
but it's a compromise between repeating the same tricky code (which is dangerous) and repeating the same
ugly code (which is error and cargo-cult prone).

CI is green: https://travis-ci.org/pantsbuild/pants/builds/92484970

Bugs closed: 2602, 2605

Reviewed at https://rbcommons.com/s/twitter/r/3160/

Coverage Stats

Jobs

ID	Job ID	Ran
1	8016.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	21 Nov 2015 10:27PM UTC	Travis Job 8016.1
4	8016.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	21 Nov 2015 10:36PM UTC	Travis Job 8016.4
5	8016.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	21 Nov 2015 10:23PM UTC	Travis Job 8016.5
6	8016.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	21 Nov 2015 10:31PM UTC	Travis Job 8016.6
7	8016.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	21 Nov 2015 10:38PM UTC	Travis Job 8016.7
8	8016.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	21 Nov 2015 10:35PM UTC	Travis Job 8016.8
9	8016.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	21 Nov 2015 10:35PM UTC	Travis Job 8016.9
10	8016.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	21 Nov 2015 10:37PM UTC	Travis Job 8016.10

Source Files on build 8016

Detailed source file information is not available for this build.

pantsbuild / pants / 8016
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8016

pantsbuild / pants / 8016 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8016

pantsbuild / pants / 8016
0%
main: 93%

README BADGES
x