7988
0%
main: 93%

Ran 20 Nov 2015 02:25AM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7988

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Fix a bug preventing re-upload artifacts that encountered read-errors

We have this function from [rb/1361](https://rbcommons.com/s/twitter/r/1361) to write generated artifacts back to cache
for artifacts encountered read errors. Unfortunately this probably never worked.
```
  elif isinstance(was_in_cache, UnreadableArtifact):
    self._cache_key_errors.update(was_in_cache.key)
```

`set.update` takes iterable, since `was_in_cache.key` is a namedtuple of three
elements, we get a set of these three elements instead of the cacheKey, and
subsequent check when it comes to write generated artifact back will fail.

Change `update` to `add` fixes this

Testing Done:
https://travis-ci.org/peiyuwang/pants/builds/91542791

Bugs closed: 2584

Reviewed at https://rbcommons.com/s/twitter/r/3141/

Coverage Stats

Jobs

ID	Job ID	Ran
1	7988.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	20 Nov 2015 02:28AM UTC	Travis Job 7988.1
4	7988.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	20 Nov 2015 02:34AM UTC	Travis Job 7988.4
5	7988.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	20 Nov 2015 02:25AM UTC	Travis Job 7988.5
6	7988.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	20 Nov 2015 02:33AM UTC	Travis Job 7988.6
7	7988.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	20 Nov 2015 02:38AM UTC	Travis Job 7988.7
8	7988.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	20 Nov 2015 02:36AM UTC	Travis Job 7988.8
9	7988.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	20 Nov 2015 02:34AM UTC	Travis Job 7988.9
10	7988.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	20 Nov 2015 02:39AM UTC	Travis Job 7988.10

Source Files on build 7988

Detailed source file information is not available for this build.

pantsbuild / pants / 7988
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7988

pantsbuild / pants / 7988 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7988

pantsbuild / pants / 7988
0%
main: 93%

README BADGES
x