pantsbuild / pants / 7954
0%
main: 93%

LAST BUILD BRANCH: multiplatform_pex_with_uv
DEFAULT BRANCH: main
Ran
Jobs 8
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7954

push

travis-ci

stuhood 
Fix cases where transitivity is required despite strict_deps; enable within the repo for Java

This patch fixes two cases where transitive deps are required at compile time despite `strict_deps`:

1. `target` aliases: the direct deps search now walks through aliases (but not fully transitively). In particular, when depending on the alias `3rdparty:protobuf-java`, it is resolved to `3rdparty:protobuf-2.4.1`
2. "compiler plugins": for code that runs in the compiler, compiletime is actually runtime, so transitive deps must be provided

The patch also enabled `strict_deps` for Java code within the repo, and applies it explicitly to zinc.

----

There is one open question represented by a few TODOs in the patch: should it be possible for a target `A`, depended on by target `B`, to add additional deps for `B`? Some potential usecases represented by TODOs in the patch:

* @Annotation interfaces seem to be required in cases where a class in package `B` inherits from an annotated class in package `A`
* In codegen, it will frequently be the case that it is impossible to use the generated code in target `A` without importing a runtime library in target `B`
* Also in codegen, there are cases where deps are directly inserted into the build graph without existing on disk (see `wire-runtime`), and where writing them out to disk (anywhere other than in `BUILD.tools`) would make it very likely for them to go out of sync with the in memory declaration.

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/91487624

Bugs closed: 2565

Reviewed at https://rbcommons.com/s/twitter/r/3125/
Jobs
ID Job ID Ran Files Coverage
1 7954.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 7954.1
4 7954.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 7954.4
5 7954.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 7954.5
6 7954.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 7954.6
7 7954.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 7954.7
8 7954.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 7954.8
9 7954.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 7954.9
10 7954.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 7954.10
Source Files on build 7954
Detailed source file information is not available for this build.