7923
0%
main: 93%

Ran 14 Nov 2015 01:21AM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7923

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Allow per-jvm-target configuration of fatal warnings

Problem

Given a large codebase with many warnings that are ignored in practice, it's very expensive to simply add `-Xfatal-warnings` (scala) or `-Werror` (java) to the compiler args, since that'd require actually fixing all the warnings in one go.  This means that developers/projects that desire fatal warnings cannot have them, and fatal warnings cannot be made the default for new code.

Solution

Add a compile.zinc option `default-fatal-warnings` that controls whether fatal warnings are enabled in compilation.
Add a jvm_target option `fatal_warnings` that trumps `--compile-zinc-default-fatal-warnings` for that particular target.

Result

Large legacy codebases with warnings can:
set `default-fatal-warnings` to `False` and allow individual targets to opt in as appropriate
or
set `default-fatal-warnings` to `True`, add `fatal_warnings=False` to all existing jvm targets in their BUILD files, and work on removing those lines target by target, while new targets get fatal warnings by default.

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/91050661

Bugs closed: 2504

Reviewed at https://rbcommons.com/s/twitter/r/3080/

Coverage Stats

Jobs

ID	Job ID	Ran
1	7923.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	14 Nov 2015 01:27AM UTC	Travis Job 7923.1
4	7923.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	14 Nov 2015 01:32AM UTC	Travis Job 7923.4
5	7923.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	14 Nov 2015 01:23AM UTC	Travis Job 7923.5
6	7923.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	14 Nov 2015 01:21AM UTC	Travis Job 7923.6
7	7923.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	14 Nov 2015 01:33AM UTC	Travis Job 7923.7
8	7923.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	14 Nov 2015 01:32AM UTC	Travis Job 7923.8
9	7923.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	14 Nov 2015 01:34AM UTC	Travis Job 7923.9
10	7923.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	14 Nov 2015 01:39AM UTC	Travis Job 7923.10

Source Files on build 7923

Detailed source file information is not available for this build.

pantsbuild / pants / 7923
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7923

pantsbuild / pants / 7923 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7923

pantsbuild / pants / 7923
0%
main: 93%

README BADGES
x