7853
0%
main: 93%

Ran 10 Nov 2015 03:47PM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7853

Build Type

push

travis-ci

Committed by

gmalmquist

Commit Message

Fixing malformatted xml report names from junit runner.

In https://rbcommons.com/s/twitter/r/3090/ I got the junit runner
to anticipate getting Descriptions with class names and method
names that were actually descriptions from frameworks like
cucumber. This stopped the runner from failing out with an NPE and
solved the internal use case I was checking against, but it turns
out there's another problem I overlooked (uncovered by running it
against another internal use-case).

The TestSuite names were also used to generate the filenames of the
xml reports. This does not work when the file name is some crazy
Cucumber scenario description complete with special characters and
who knows what.

So this sanitizes the name used for generating the xml file.

Testing Done:
Extended existing integration test for cucumber to include Scenarios
that would otherwise generate bad file names, and verified that this
change fixes our internal problem.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/90160989
CI went green here: https://travis-ci.org/gmalmquist/pants/builds/90160881

Bugs closed: 2529

Reviewed at https://rbcommons.com/s/twitter/r/3103/

Coverage Stats

Jobs

ID	Job ID	Ran
1	7853.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	10 Nov 2015 03:52PM UTC	Travis Job 7853.1
4	7853.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	10 Nov 2015 04:01PM UTC	Travis Job 7853.4
5	7853.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	10 Nov 2015 03:47PM UTC	Travis Job 7853.5
6	7853.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	10 Nov 2015 03:58PM UTC	Travis Job 7853.6
7	7853.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	10 Nov 2015 03:59PM UTC	Travis Job 7853.7
8	7853.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	10 Nov 2015 03:59PM UTC	Travis Job 7853.8
9	7853.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	10 Nov 2015 03:59PM UTC	Travis Job 7853.9
10	7853.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	10 Nov 2015 04:04PM UTC	Travis Job 7853.10

Source Files on build 7853

Detailed source file information is not available for this build.

pantsbuild / pants / 7853
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7853

pantsbuild / pants / 7853 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7853

pantsbuild / pants / 7853
0%
main: 93%

README BADGES
x