7698
0%
main: 93%

Ran 02 Nov 2015 06:29PM UTC

Jobs 8

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 7698

Build Type

push

travis-ci

Committed by Benjy

Commit Message

Refactor the python checkstyle plugin system.

Now instead of the plugins knowing about their corresponding
subsystems, the subsystems know about (and create) the plugins.

This allows us to only import (and therefore parse and interpret)
code we're actually going to use.  Performance profiles show that
almost a second of startup time is spent just loading backends,
and checkstyle was a good chunk of that.

If we like how this works, we can contemplate something similar
for backend code in general. Right now we load huge amounts of code
even if we never invoke it.

This change also creates some useful unittest infrastructure for
testing these checkstyle plugins. As a result it switches all
the relevant tests to use our idiomatic style (self.assertTrue
instead of assert keyword, and so on).

Testing Done:
CI passes: https://travis-ci.org/pantsbuild/pants/builds/88461495

Reviewed at https://rbcommons.com/s/twitter/r/3061/

Coverage Stats

Jobs

ID	Job ID	Ran
1	7698.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	02 Nov 2015 06:32PM UTC	Travis Job 7698.1
4	7698.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	02 Nov 2015 06:38PM UTC	Travis Job 7698.4
5	7698.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	02 Nov 2015 06:29PM UTC	Travis Job 7698.5
6	7698.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	02 Nov 2015 06:36PM UTC	Travis Job 7698.6
7	7698.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	02 Nov 2015 06:40PM UTC	Travis Job 7698.7
8	7698.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	02 Nov 2015 06:45PM UTC	Travis Job 7698.8
9	7698.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	02 Nov 2015 06:41PM UTC	Travis Job 7698.9
10	7698.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	02 Nov 2015 06:43PM UTC	Travis Job 7698.10

Source Files on build 7698

Detailed source file information is not available for this build.

pantsbuild / pants / 7698
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7698

pantsbuild / pants / 7698 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7698

pantsbuild / pants / 7698
0%
main: 93%

README BADGES
x